Skip to content

[https://nvbugs/5924144][test] unwaive cpp/test_unit_tests.py::test_unit_tests[kernels-80]#11902

Merged
MartinMarciniszyn merged 1 commit intoNVIDIA:mainfrom
Funatiq:dev/fix/5924144
Mar 9, 2026
Merged

[https://nvbugs/5924144][test] unwaive cpp/test_unit_tests.py::test_unit_tests[kernels-80]#11902
MartinMarciniszyn merged 1 commit intoNVIDIA:mainfrom
Funatiq:dev/fix/5924144

Conversation

@Funatiq
Copy link
Collaborator

@Funatiq Funatiq commented Mar 4, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Removed a waived test entry from the test configuration.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@Funatiq
Copy link
Collaborator Author

Funatiq commented Mar 4, 2026

/bot run --stage-list "A30-CPP-2"

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 4, 2026

PR_Github #37666 [ run ] triggered by Bot. Commit: 2cfd656 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 4, 2026

PR_Github #37666 [ run ] completed with state SUCCESS. Commit: 2cfd656
/LLM/main/L0_MergeRequest_PR pipeline #29150 (Partly Tested) completed with status: 'SUCCESS'

Link to invocation

@Funatiq
Copy link
Collaborator Author

Funatiq commented Mar 4, 2026

/bot run --stage-list "A30-CPP-2"

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 4, 2026

PR_Github #37688 [ run ] triggered by Bot. Commit: 2cfd656 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 4, 2026

PR_Github #37688 [ run ] completed with state SUCCESS. Commit: 2cfd656
/LLM/main/L0_MergeRequest_PR pipeline #29170 (Partly Tested) completed with status: 'SUCCESS'

Link to invocation

@Funatiq Funatiq requested a review from EmmaQiaoCh March 4, 2026 12:52
@Funatiq Funatiq marked this pull request as ready for review March 4, 2026 12:52
@Funatiq Funatiq changed the title [test] unwaive cpp/test_unit_tests.py::test_unit_tests[kernels-80] [https://nvbugs/5924144][test] unwaive cpp/test_unit_tests.py::test_unit_tests[kernels-80] Mar 4, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

A single test waiver entry for cpp/test_unit_tests.py::test_unit_tests[kernels-80] was removed from the waives configuration file, reducing the number of waived tests by one.

Changes

Cohort / File(s) Summary
Test Waiver Removal
tests/integration/test_lists/waives.txt		 Removed one skip-entry line for cpp/test_unit_tests.py::test_unit_tests[kernels-80] with associated issue reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely a template with no custom content provided for required sections like Description and Test Coverage. Fill in the Description section explaining why the test waiver is being removed and the Test Coverage section describing validation approach.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly summarizes the main change: removing a waived test entry, with the specific test name and bug reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@Funatiq
Copy link
Collaborator Author

Funatiq commented Mar 4, 2026

/bot skip --comment "Unwaived test has passed"

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 4, 2026

PR_Github #37700 [ skip ] triggered by Bot. Commit: 2cfd656 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 4, 2026

PR_Github #37700 [ skip ] completed with state SUCCESS. Commit: 2cfd656
Skipping testing for commit 2cfd656

Link to invocation

@Funatiq
Copy link
Collaborator Author

Funatiq commented Mar 5, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 5, 2026

PR_Github #37834 [ reuse-pipeline ] triggered by Bot. Commit: c706e79 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 5, 2026

PR_Github #37834 [ reuse-pipeline ] completed with state SUCCESS. Commit: c706e79
Reusing PR_Github #37688 (Partly Tested) for commit c706e79

Link to invocation

@Funatiq
[test] unwaive cpp/test_unit_tests.py::test_unit_tests[kernels-80]
b0a7999 
Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
@Funatiq
Copy link
Collaborator Author

Funatiq commented Mar 9, 2026

/bot reuse-pipeline

@Funatiq Funatiq requested a review from DomBrown March 9, 2026 15:26
@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 9, 2026

PR_Github #38286 [ reuse-pipeline ] triggered by Bot. Commit: b0a7999 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Mar 9, 2026

PR_Github #38286 [ reuse-pipeline ] completed with state SUCCESS. Commit: b0a7999
Reusing PR_Github #37688 (Partly Tested) for commit b0a7999

Link to invocation

@MartinMarciniszyn MartinMarciniszyn merged commit 27cab47 into NVIDIA:main Mar 9, 2026
5 checks passed
@Funatiq Funatiq deleted the dev/fix/5924144 branch March 9, 2026 16:07
tianyuz-nv pushed a commit to wanqian-nv/TensorRT-LLM that referenced this pull request Mar 19, 2026
@Funatiq
[https://nvbugs/5924144][test] unwaive cpp/test_unit_tests.py::test_u…
78dc644 
…nit_tests[kernels-80] (NVIDIA#11902)

Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
limin2021 pushed a commit to limin2021/TensorRT-LLM that referenced this pull request Mar 19, 2026
@Funatiq
[https://nvbugs/5924144][test] unwaive cpp/test_unit_tests.py::test_u…
421db94 
…nit_tests[kernels-80] (NVIDIA#11902)

Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinMarciniszyn MartinMarciniszyn MartinMarciniszyn approved these changes

@EmmaQiaoCh EmmaQiaoCh Awaiting requested review from EmmaQiaoCh

@DomBrown DomBrown Awaiting requested review from DomBrown

Assignees

@Funatiq Funatiq

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Funatiq @tensorrt-cicd @MartinMarciniszyn